[webkit-reviews] review granted: [Bug 32390] Crash in WebCore::SplitElementCommand::SplitElementCommand ReadAV at NULL (3d3ebb81789addf3fcdd28c39a72b244) : [Attachment 46427] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 26 14:13:27 PST 2010


Eric Seidel <eric at webkit.org> has granted Tony Chang (Google)
<tony at chromium.org>'s request for review:
Bug 32390: Crash in WebCore::SplitElementCommand::SplitElementCommand
ReadAV at NULL (3d3ebb81789addf3fcdd28c39a72b244)
https://bugs.webkit.org/show_bug.cgi?id=32390

Attachment 46427: Patch
https://bugs.webkit.org/attachment.cgi?id=46427&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think the fix and test are fine.  Certainly better than crashing.

You should add a FIXME next to your fix saying that enclosingBlock should
eventually be fixed instead.


More information about the webkit-reviews mailing list