[webkit-reviews] review requested: [Bug 33365] webkit-patch's use of auto-install is dropping autoinstall directories everywhere : [Attachment 47447] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 26 14:12:56 PST 2010


Chris Jerdonek <cjerdonek at webkit.org> has asked  for review:
Bug 33365: webkit-patch's use of auto-install is dropping autoinstall
directories everywhere
https://bugs.webkit.org/show_bug.cgi?id=33365

Attachment 47447: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=47447&action=review

------- Additional Comments from Chris Jerdonek <cjerdonek at webkit.org>
The cache directory gets created when "import" is called for an external module
(when searching for the module to import), rather than when autoinstall.py is
first processed.

Other possibilities would be to change the working directory prior to calling
"import" for an external module, or to trigger the cache directory to get
created while still inside __init__.py, but this seems most straightforward.


More information about the webkit-reviews mailing list