[webkit-reviews] review granted: [Bug 34074] Convert textarea-rows-cols.html to dumpAsText() : [Attachment 47387] Proposed patch (rev.2)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 25 22:17:26 PST 2010
Shinichiro Hamaji <hamaji at chromium.org> has granted TAMURA, Kent
<tkent at chromium.org>'s request for review:
Bug 34074: Convert textarea-rows-cols.html to dumpAsText()
https://bugs.webkit.org/show_bug.cgi?id=34074
Attachment 47387: Proposed patch (rev.2)
https://bugs.webkit.org/attachment.cgi?id=47387&action=review
------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Thanks for the fix! r+ assuming you'll address the comment below and combine
patch v1 and v2 into a single patch.
> -shouldBeTrue('defaultHeight > 0');
> -shouldBeTrue('defaultWidth > 0');
I guess we don't need to remove them?
More information about the webkit-reviews
mailing list