[webkit-reviews] review granted: [Bug 30546] Storage events don't quite match the current spec; need to fix : [Attachment 47242] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jeremy Orlow <jorlow at chromium.org>'s
request for review:
Bug 30546: Storage events don't quite match the current spec; need to fix
https://bugs.webkit.org/show_bug.cgi?id=30546

Attachment 47242: Patch
https://bugs.webkit.org/attachment.cgi?id=47242&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +void Document::storageEventTimerFired(Timer<Document>*)
> +{
> +    Vector<RefPtr<Event> > storageEventQueue;
> +    storageEventQueue.swap(m_storageEventQueue);
> +
> +    typedef Vector<RefPtr<Event> >::const_iterator Iterator;
> +    Iterator end = storageEventQueue.end();
> +    for (Iterator it = storageEventQueue.begin(); it != end; ++it)
> +	   dispatchWindowEvent(*it);
> +}

Is there any time late in the lifetime of a document where the object has not
been destroyed, but it would not be a good time to call dispatchWindowEvent? I
guess the domWindow() function will return 0 in that case, so probably the
answer is no.

r=me