[webkit-reviews] review granted: [Bug 33821] REGRESSION (r53110): Find My iPhone message dialog is offset from original position once it gets focus : [Attachment 47230] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 22 17:00:22 PST 2010
mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 33821: REGRESSION (r53110): Find My iPhone message dialog is offset from
original position once it gets focus
https://bugs.webkit.org/show_bug.cgi?id=33821
Attachment 47230: Patch
https://bugs.webkit.org/attachment.cgi?id=47230&action=review
------- Additional Comments from mitz at webkit.org
> + RenderLayer* currLayer = parent();
> + while (currLayer) {
> + if (currLayer == ancestorLayer)
> + foundAncestor = true;
> +
> + if (isFixedPositionedContainer(currLayer)) {
> + fixedPositionContainerLayer = currLayer;
> + ASSERT(foundAncestor);
> + break;
> + }
> +
> + currLayer = currLayer->parent();
> + }
Can be written as a for loop with currLayer in the scope of the loop.
More information about the webkit-reviews
mailing list