[webkit-reviews] review granted: [Bug 32258] Rename fast/websockets to fast/websocket : [Attachment 47105] Patch

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has granted  review:
Bug 32258: Rename fast/websockets to fast/websocket
https://bugs.webkit.org/show_bug.cgi?id=32258

Attachment 47105: Patch
https://bugs.webkit.org/attachment.cgi?id=47105&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Thanks for the clarifications!

> > I guess you forgot to add TEMPLATE.html ? 
> 
> I think TEMPLATE.html already exists in websocket/tests/script-tests/

Ah, I see. I didn't notice that. Looks good then.

> Hmm, git status shows "renamed:
> LayoutTests/fast/websockets/script-tests/websocket-event-target.js ->
> LayotuTests/websocket/tests/script-tests/websocket-event-target.js" or so,
but
> "webkit-patch prepare" provided the ChangeLog as in attachment.

I guess it's because you changed the content slightly?