[webkit-reviews] review denied: [Bug 32258] Rename fast/websockets to fast/websocket : [Attachment 47105] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 21 01:39:24 PST 2010


Shinichiro Hamaji <hamaji at chromium.org> has denied Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 32258: Rename fast/websockets to fast/websocket
https://bugs.webkit.org/show_bug.cgi?id=32258

Attachment 47105: Patch
https://bugs.webkit.org/attachment.cgi?id=47105&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
> diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
> index d63a7d9..50d0689 100644
> --- a/LayoutTests/ChangeLog
> +++ b/LayoutTests/ChangeLog
> @@ -1,3 +1,18 @@
> +2010-01-21  Fumitoshi Ukai  <ukai at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Move fast/websockets into websocket/tests
> +	   https://bugs.webkit.org/show_bug.cgi?id=32258
> +
> +	   * fast/websockets/script-tests/TEMPLATE.html: Removed.
> +	   * fast/websockets/script-tests/websocket-event-target.js: Removed.
> +	   * fast/websockets/websocket-event-target-expected.txt: Removed.
> +	   * fast/websockets/websocket-event-target.html: Removed.
> +	   * websocket/tests/script-tests/websocket-event-target.js: Added.
> +	   * websocket/tests/websocket-event-target-expected.txt: Added.
> +	   * websocket/tests/websocket-event-target.html: Added.

I guess you forgot to add TEMPLATE.html ? I'm not sure, but if you used git mv
create this patch, prepare-ChangeLog should print "Renamed from ..." instead of
"Added" ?


More information about the webkit-reviews mailing list