[webkit-reviews] review canceled: [Bug 33150] Do not render the full frame when there is some elements with fixed positioning : [Attachment 46999] Repaint only the invalidated area after scrolling

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin.poulain at nokia.com> has canceled Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 33150: Do not render the full frame when there is some elements with fixed
positioning
https://bugs.webkit.org/show_bug.cgi?id=33150

Attachment 46999: Repaint only the invalidated area after scrolling
https://bugs.webkit.org/attachment.cgi?id=46999&action=review

------- Additional Comments from Benjamin Poulain <benjamin.poulain at nokia.com>
Update from the comments:

> Why is this test needed? Isn't it true for all fixed positioned objects in
the
> hash?

I added a comment as you suggested on IRC.

> (un)registerFixedPositionedObject would be a better name
> m_fixedPositionedObjects

Updated.

> Need to remove the FIXME that this patch fixes:
> 
> --// FIXME: A better solution would be to only invalidate the fixed regions
> when scrolling. It's overkill to
> --// prevent the entire view from blitting on a scroll.

Good point :)