[webkit-reviews] review requested: [Bug 33903] FTBFS on GNU/kFreeBSD caused by missing strnstr() on glibc systems : [Attachment 47028] fix kfreebsd ftbfs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 20 07:29:29 PST 2010


Fathi Boudra <fabo at debian.org> has asked  for review:
Bug 33903: FTBFS on GNU/kFreeBSD caused by missing strnstr() on glibc systems
https://bugs.webkit.org/show_bug.cgi?id=33903

Attachment 47028: fix kfreebsd ftbfs
https://bugs.webkit.org/attachment.cgi?id=47028&action=review

------- Additional Comments from Fathi Boudra <fabo at debian.org>
While building Qt 4.6.1 on GNU/kFreeBSD, it fails to build from scratch:
websockets/WebSocketHandshake.cpp: In member function ‘int
WebCore::WebSocketHandshake::readServerHandshake(const char*, size_t)’:
websockets/WebSocketHandshake.cpp:255: error: ‘strnstr’ was not declared in
this scope

it's caused by the missing strnstr() function on glibc systems.

webkit trunk should be also affected as the source code found on Qt 4.6.1 is
similar.

Please, find attached an initial patch to fix the issue.


More information about the webkit-reviews mailing list