[webkit-reviews] review denied: [Bug 32912] Implement File and Blob interfaces as defined in File API spec. : [Attachment 46927] Proposed Patch

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has denied Jian Li <jianli at chromium.org>'s
request for review:
Bug 32912: Implement File and Blob interfaces as defined in File API spec.
https://bugs.webkit.org/show_bug.cgi?id=32912

Attachment 46927: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=46927&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
Almost there. Would be nice to get it building on trybots though since it's
mostly a change to build files...

> diff --git a/WebCore/bindings/objc/PublicDOMInterfaces.h
b/WebCore/bindings/objc/PublicDOMInterfaces.h

> + at property(readonly, copy) NSString *type;
> + at property(readonly, copy) NSString *urn;

These are from a future patch. Should be removed.

> diff --git a/WebCore/html/Blob.cpp b/WebCore/html/Blob.cpp

> + * Copyright (C) 2009 Google Inc. All rights reserved.

2009 -> 2010?

> +unsigned long long Blob::size() const
> +{
> +    if (m_length != -1)
> +	   return static_cast<unsigned long long>(m_length);

Since this patch does not depend on Blob holding m_length and m_start, lets not
add them in this patch. They will be added as part of slice() I think.

> diff --git a/WebCore/html/Blob.h b/WebCore/html/Blob.h

> + * Copyright (C) 2009 Google Inc. All rights reserved.

2010

> diff --git a/WebCore/html/Blob.idl b/WebCore/html/Blob.idl

> + * Copyright (C) 2009 Google Inc. All rights reserved.

2010

> +File::~File()

Does it need an empty destructor?