[webkit-reviews] review granted: [Bug 33403] [OpenVG] Add (EGL) surface/context management : [Attachment 46930] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Jakob Petsovits
<jpetsovits at rim.com>'s request for review:
Bug 33403: [OpenVG] Add (EGL) surface/context management
https://bugs.webkit.org/show_bug.cgi?id=33403

Attachment 46930: Patch
https://bugs.webkit.org/attachment.cgi?id=46930&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Looks great, some small style fixes remaining, please fix before landing:


> +	   static const EGLint configAttribs[] = {
> +	       EGL_RED_SIZE, 8,
....
> +	       EGL_NONE };

The }; needs to go in another line, aligned with the "static const" prefix.
There are several places in the patch that need to be fixed.


> +    WTF::HashMap<EGLSurface, SurfaceOpenVG*> m_platformSurfaces;
> +    WTF::HashMap<EGLNativeWindowType, EGLSurface> m_windowSurfaces;
> +    WTF::HashMap<EGLSurface, EGLint> m_surfaceConfigIds;
> +    WTF::HashMap<EGLint, EGLint> m_compatibleConfigIds;
> +    WTF::HashMap<EGLint, EGLContext> m_contexts;

Remove WTF:: prefixes. HashMap uses "using WTF::HashMap", so it's available in
all namespaces.
Thanks for the patience... r=me.