[webkit-reviews] review requested: [Bug 33791] check-webkit-style: Checking patch does not work when script not run from source root : [Attachment 46809] Proposed patch

[bugzilla-daemon at webkit.org]

Chris Jerdonek <cjerdonek at webkit.org> has asked  for review:
Bug 33791: check-webkit-style: Checking patch does not work when script not run
from source root
https://bugs.webkit.org/show_bug.cgi?id=33791

Attachment 46809: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=46809&action=review

------- Additional Comments from Chris Jerdonek <cjerdonek at webkit.org>
[Serial patch: this patch assumes the patch from bug 33775 has been checked in
(awaiting review). As a result, the status bots may not work.]

In this patch, in addition to the one-line fix, I'm also experimenting with a
new way to manage intra-package references.  As a sibling to the style/ folder,
I'm adding a style_references.py module to house external dependencies.  The
reasoning behind this is more fully explained in the code comments at the
beginning of style_references.py.

As a side benefit, this also allows us to remove the __path__ hack that I added
a while back to __init__.py.  See, for instance--

https://bugs.webkit.org/show_bug.cgi?id=32971#c3
https://bugs.webkit.org/show_bug.cgi?id=32971#c6