[webkit-reviews] review requested: [Bug 31470] [Gtk] For removing ICU, implement IDN support by means of libidn : [Attachment 46657] IDN support through libidn

[bugzilla-daemon at webkit.org]

Dominik Röttsches <dominik.roettsches at access-company.com> has asked  for
review:
Bug 31470: [Gtk] For removing ICU, implement IDN support by means of libidn
https://bugs.webkit.org/show_bug.cgi?id=31470

Attachment 46657: IDN support through libidn
https://bugs.webkit.org/attachment.cgi?id=46657&action=review

------- Additional Comments from Dominik Röttsches
<dominik.roettsches at access-company.com>
(In reply to comment #4)
> (From update of attachment 44621 [details])

> A nitpick, but I guess retValue or something like that would be better than
> 'err', since the variable does not necessarily denote an error.
> [...]
> I very much prefer to rely on pkg-config for this, as we do everywhere else.

Comments addressed.

> Also, is there any chance this could be folded into glib at some point?
> Depending on a new library for a single function is kind of silly.

I agree - but don't know about such plans. I could file it as an issue for
glib.