[webkit-reviews] review requested: [Bug 29564] [Qt] Webkit Button Size : [Attachment 46656] Patch with test case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 15 01:46:25 PST 2010


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 29564: [Qt] Webkit Button Size
https://bugs.webkit.org/show_bug.cgi?id=29564

Attachment 46656: Patch with test case
https://bugs.webkit.org/attachment.cgi?id=46656&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Notice, the Mac ports ignore the specified height for <input type="button">
elements unless a border, and/or background CSS property is also specified
(because method RenderTheme::isControlStyled returns false on line 72 of
RenderTheme.cpp
<http://trac.webkit.org/browser/trunk/WebCore/rendering/RenderTheme.cpp?rev=524
32#L72>).


More information about the webkit-reviews mailing list