[webkit-reviews] review requested: [Bug 33498] REGRESSION: svg/css/circle-in-mask-with-shadow.svg failing pixel tests : [Attachment 46643] proposed fix for Qt port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 14 22:46:35 PST 2010


Csaba Osztrogonac <ossy at webkit.org> has asked  for review:
Bug 33498: REGRESSION: svg/css/circle-in-mask-with-shadow.svg failing pixel
tests
https://bugs.webkit.org/show_bug.cgi?id=33498

Attachment 46643: proposed fix for Qt port
https://bugs.webkit.org/attachment.cgi?id=46643&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
Qt port has own expected files for SVG tests, because sometimes small pixel can
be occured (because of different fonts) and some other reason. eg. MACs dump
SVG path with fixed point (2 decimal) number, Qt port dump it with floating
point number (so many decimal as need). The latter thing is not so good, I'm
going to refactor it to be same to MAC. (I prepared a patch before, but some
tests should be updated with it.)

Now we should update results. The differents are analogous as in
http://trac.webkit.org/changeset/53300


More information about the webkit-reviews mailing list