[webkit-reviews] review denied: [Bug 33160] history.pushState should clear the entire forward history : [Attachment 46608] v1 patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Darin Fisher (:fishd, Google)
<fishd at chromium.org>'s request for review:
Bug 33160: history.pushState should clear the entire forward history
https://bugs.webkit.org/show_bug.cgi?id=33160

Attachment 46608: v1 patch
https://bugs.webkit.org/attachment.cgi?id=46608&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
The indirection of insertItemAfterCurrent() is no longer necessary.

The only reason the private insertItemAfterCurrent() was added in the first
place was to differentiate between a pushState() and an addItem().  Now that
the distinction is removed, I'd rather see the body of insertItemAfterCurrent()
moved back into addItem(), and have pushState() call addItem().

(Otherwise, looks good)