[webkit-reviews] review granted: [Bug 31283] position:fixed and transform on same element breaks fixed behavior : [Attachment 46404] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 12 16:11:04 PST 2010
mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 31283: position:fixed and transform on same element breaks fixed behavior
https://bugs.webkit.org/show_bug.cgi?id=31283
Attachment 46404: Patch
https://bugs.webkit.org/attachment.cgi?id=46404&action=review
------- Additional Comments from mitz at webkit.org
> + EPosition position;
> + if ((position = renderer()->style()->position()) == FixedPosition) {
> + if (!ancestorLayer || ancestorLayer == renderer()->view()->layer())
{
Please just initialize position first, then do a single if statement:
if (position == FixedPosition && (!ancestorLayer || ancestorLayer ==
renderer()->view()->layer())) {
…
r=me
More information about the webkit-reviews
mailing list