[webkit-reviews] review requested: [Bug 32884] CSS2.1 Counters not updated when new elements are inserted in the DOM. : [Attachment 46407] Proposed Patch; Addressed Darin's concerns. Removed an invalid assertion and handled the case.

[bugzilla-daemon at webkit.org]

Carol Szabo <carol.szabo at nokia.com> has asked  for review:
Bug 32884: CSS2.1 Counters not updated when new elements are inserted in the
DOM.
https://bugs.webkit.org/show_bug.cgi?id=32884

Attachment 46407: Proposed Patch; Addressed Darin's concerns. Removed an
invalid assertion and handled the case.
https://bugs.webkit.org/attachment.cgi?id=46407&action=review

------- Additional Comments from Carol Szabo <carol.szabo at nokia.com>
Darin,
Unfortunately it is not possible to check the assertion in the comment you
referred to above since the map may be empty for brief periods of time, but it
should be soon filled. If you want, though, I can remove the comment, delete
the map and incur the performance and code size penalty, but I'd like you to
consider, first, the following additional information:
- in the destructor of RenderObject "destroyCounters" is called, which deletes
the map, so as long as this stays true, the map is not leaked, it is just
cashed.
- this function is only called from within the counters code which is small and
should be easy to check for making the correct calls.