[webkit-reviews] review granted: [Bug 31597] locale for text breakiterator and string search is not set to the UI locale : [Attachment 46383] update to use the macro for static local variable

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 12 11:21:39 PST 2010


Jungshik Shin <jshin at chromium.org> has granted	review:
Bug 31597: locale for text breakiterator and string search is not set to the UI
locale
https://bugs.webkit.org/show_bug.cgi?id=31597

Attachment 46383: update to use the macro for static local variable
https://bugs.webkit.org/attachment.cgi?id=46383&action=review

------- Additional Comments from Jungshik Shin <jshin at chromium.org>
thanks for the review. 
I've seen that macro but was mistaken for that to be only used with a literal
value. 
I updated the patch to use the macro for static local (to leak at the end of a
process) and pulled in the helper function into WebCore ns.

I'm carrying along r+ for the updated patch and will plus commit-queue once
chrome-bot comes back green (although I locally built and ran some tests)


More information about the webkit-reviews mailing list