[webkit-reviews] review granted: [Bug 33537] More Complete Print Implementation : [Attachment 46380] Extend and improve example print implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 12 11:01:11 PST 2010


Darin Adler <darin at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 33537: More Complete Print Implementation
https://bugs.webkit.org/show_bug.cgi?id=33537

Attachment 46380: Extend and improve example print implementation
https://bugs.webkit.org/attachment.cgi?id=46380&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    //rect->right -= MARGIN; 
> +    //rect->bottom -= MARGIN;

Why leave commented-out code in?

> +   HDC dc = ::GetDC (0);
> +
> +   TEXTMETRIC textMetric;
> +   ::GetTextMetrics (dc, &textMetric);
> +   ::ReleaseDC (0, dc);

Spaces before parentheses here, not usually our style.

Looks OK, rs=me


More information about the webkit-reviews mailing list