[webkit-reviews] review denied: [Bug 33415] VCSUtils::gitdiff2svndiff() should accept strings ending in a newline : [Attachment 46196] Patch 3

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Chris Jerdonek
<chris.jerdonek at gmail.com>'s request for review:
Bug 33415: VCSUtils::gitdiff2svndiff() should accept strings ending in a
newline
https://bugs.webkit.org/show_bug.cgi?id=33415

Attachment 46196: Patch 3
https://bugs.webkit.org/attachment.cgi?id=46196&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> Index: WebKitTools/Scripts/VCSUtils.pm
> +    # \V is any character that is not vertical white space
> +    if (m#^diff --git \w/(.+) \w/(\V+)#) {
> +	   return "Index: $1${^POSTMATCH}";
> +    }

Yes, you should use 'p' modifier with ${^POSTMATCH} and friends (per the perlre
manpage).

To use $POSTMATCH instead of $', you need the "use English;" statement.

r- to either add the 'p' switches or go back to using $POSTMATCH with 'use
English'.  (I'd go back to using $' or $POSTMATCH since I'm not sure everyone
is running Perl 5.10 or newer yet.)