[webkit-reviews] review requested: [Bug 33415] VCSUtils::gitdiff2svndiff() should accept strings ending in a newline : [Attachment 46196] Patch 3

[bugzilla-daemon at webkit.org]

Chris Jerdonek <chris.jerdonek at gmail.com> has asked  for review:
Bug 33415: VCSUtils::gitdiff2svndiff() should accept strings ending in a
newline
https://bugs.webkit.org/show_bug.cgi?id=33415

Attachment 46196: Patch 3
https://bugs.webkit.org/attachment.cgi?id=46196&action=review

------- Additional Comments from Chris Jerdonek <chris.jerdonek at gmail.com>
Thanks for the comments, guys! :)

David, I incorporated your suggestions -- thanks a lot.

After reading http://perldoc.perl.org/perlre.html , it's not clear to me if I
need to use the "preserve" modifier (/p) to use ${^POSTMATCH}.	The unit tests
seem to work okay without it, so I decided to leave it off (though it's
conceivable that it's working only because of previous regexes in the tests).