[webkit-reviews] review requested: [Bug 33381] [Android] FrameLoaderClientAndroid::canHandleRequest needs to know whether the request was initiated by a user gesture : [Attachment 46138] Patch 1 for Bug 33381

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 8 08:09:18 PST 2010


Steve Block <steveblock at google.com> has asked  for review:
Bug 33381: [Android] FrameLoaderClientAndroid::canHandleRequest needs to know
whether the request was initiated by a user gesture
https://bugs.webkit.org/show_bug.cgi?id=33381

Attachment 46138: Patch 1 for Bug 33381
https://bugs.webkit.org/attachment.cgi?id=46138&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
This patch adds a new 'isUserGesture' flag to the ResourceRequest. This is set
by the FrameLoader, and can be read by the FrameLoaderClient. Due to the many
different pathways from FrameLoader to FrameLoaderClient::canHandleRequest,
this is simpler than adding userGesture arguments to many of the FrameLoader
methods.

Note that a new userGesture argument is required for loadURL as this method
creates a new ResourceRequest object.


More information about the webkit-reviews mailing list