[webkit-reviews] review granted: [Bug 31318] Windows: Implement full screen mode for <video> : [Attachment 46102] Another replacement patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 31318: Windows: Implement full screen mode for <video>
https://bugs.webkit.org/show_bug.cgi?id=31318

Attachment 46102: Another replacement patch
https://bugs.webkit.org/attachment.cgi?id=46102&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +    static LRESULT fullscreenWndProc(HWND, UINT message, WPARAM wParam,
LPARAM lParam);

No need for the wParam and lParam parameter names.

> +    bool hitTest(const WebCore::IntPoint& point) const { return point.x() >=
m_rect.x() && point.x() < m_rect.x() + m_rect.width() && point.y() >=
m_rect.y() && point.y() < m_rect.y() + m_rect.height(); }

I still think this could just be: return m_rect.contains(point);

r=me