[webkit-reviews] review denied: [Bug 31283] position:fixed and transform on same element breaks fixed behavior : [Attachment 45920] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 31283: position:fixed and transform on same element breaks fixed behavior
https://bugs.webkit.org/show_bug.cgi?id=31283

Attachment 45920: Patch
https://bugs.webkit.org/attachment.cgi?id=45920&action=review

------- Additional Comments from mitz at webkit.org
> @@ -982,9 +984,14 @@ void RenderBox::mapAbsoluteToLocalPoint(bool fixed, bool
useTransforms, Transfor
>      if (style()->position() == FixedPosition)
>	   fixed = true;
>  
> +    bool isFixedPos = style()->position() == FixedPosition;
>      bool hasTransform = hasLayer() && layer()->transform();
> -    if (hasTransform)
> -	   fixed = false;  // Elements with transforms act as a containing
block for fixed position descendants
> +    if (hasTransform) {
> +	   // If this box has a transform, it acts as a fixed position
container for fixed descendants,
> +	   // and may itself also be fixed position. So propagate 'fixed' up
only if this box is fixed position.
> +	   fixed &= isFixedPos;
> +    } else
> +	   fixed |= isFixedPos;

This doesn’t look right.