[webkit-reviews] review denied: [Bug 33004] NetworkStateNotifierWin.cpp doesn't work always : [Attachment 45584] The patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 33004: NetworkStateNotifierWin.cpp doesn't work always
https://bugs.webkit.org/show_bug.cgi?id=33004

Attachment 45584: The patch
https://bugs.webkit.org/attachment.cgi?id=45584&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +NetworkStateNotifier::~NetworkStateNotifier()
> +{
> +    m_closeAddrChangeWaitThread = true;
> +    ::CloseHandle(m_overlapped.hEvent);
> +    ::WaitForSingleObject(m_waitHandle, INFINITE);
> +    ::CloseHandle(m_waitHandle);
>  }

NetworkStateNotifier is a singleton that is never destroyed. This code will
never be called.

It seems like the real fix here is to call NotifyAddrChange again after we
receive a notification. Why can't we just add another call to
NotifyAddrChange/RegisterWaitForSingleObject inside addressChanged()?