[webkit-reviews] review requested: [Bug 31318] Windows: Implement full screen mode for <video> : [Attachment 45851] Replacement patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 4 18:07:30 PST 2010
Chris Marrin <cmarrin at apple.com> has asked for review:
Bug 31318: Windows: Implement full screen mode for <video>
https://bugs.webkit.org/show_bug.cgi?id=31318
Attachment 45851: Replacement patch
https://bugs.webkit.org/attachment.cgi?id=45851&action=review
------- Additional Comments from Chris Marrin <cmarrin at apple.com>
This addresses all of Simon and Darin's comments. In particular, I've collapsed
WebVideoFSController and WebVideoFSHUDController into a single class
FullscreenVideoController. The name is short enough to make MSDev happy and
avoids abbreviations. And these two classes had a convoluted way of
communicating with each other, so this also makes things a bit simpler.
More information about the webkit-reviews
mailing list