[webkit-reviews] review denied: [Bug 32875] [Android] Android requires ability to increase layout delay : [Attachment 45656] Patch 1 for Bug 32875

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Steve Block
<steveblock at google.com>'s request for review:
Bug 32875: [Android] Android requires ability to increase layout delay
https://bugs.webkit.org/show_bug.cgi?id=32875

Attachment 45656: Patch 1 for Bug 32875
https://bugs.webkit.org/attachment.cgi?id=45656&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> Index: WebCore/dom/Document.cpp
> ===================================================================
> --- WebCore/dom/Document.cpp	(revision 52652)
> +++ WebCore/dom/Document.cpp	(working copy)
> @@ -407,6 +407,7 @@ Document::Document(Frame* frame, bool is
>      m_processingLoadEvent = false;
>      m_startTime = currentTime();
>      m_overMinimumLayoutThreshold = false;
> +    m_extraLayoutDelay = 0;
>      
>      initSecurityContext();
>      initDNSPrefetch();

I think you should be modifying cLayoutScheduleThreshold in Document.cpp
instead of adding another member variable to Document.

Another approach (which the iPhone WebKit port uses) is to add a
'layoutInterval' item to Settings (so the value can be injected), then change
uses of cLayoutScheduleThreshold to call settings()->layoutInterval() instead. 
(The Settings::setLayoutInterval() method doesn't allow values less than
cLayoutScheduleThreshold to be set when it's called, but that requires
exporting cLayoutScheduleThreshold and removing the static keyword.)