[webkit-reviews] review denied: [Bug 33182] [V8] Move security checks for setting src to javascript url out of V8Custom : [Attachment 45843] patch minus style errors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 4 17:27:27 PST 2010


Adam Barth <abarth at webkit.org> has denied Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 33182: [V8] Move security checks for setting src to javascript url out of
V8Custom
https://bugs.webkit.org/show_bug.cgi?id=33182

Attachment 45843: patch minus style errors
https://bugs.webkit.org/attachment.cgi?id=45843&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Sorry, I think i steered you slightly wrong here.  This code can go in the
generic BindingSecurity object since it's not dependent on V8:

http://trac.webkit.org/browser/trunk/WebCore/bindings/BindingSecurity.h

That way the code will be shared with JSC eventually.


More information about the webkit-reviews mailing list