[webkit-reviews] review granted: [Bug 32571] Support the aria-checked attribute : [Attachment 45846] Makes native checkedness take precedence when checking for aria-checked. Now tests all permutations of checked and aria-checked.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dominic Mazzoni
<dmazzoni at google.com>'s request for review:
Bug 32571: Support the aria-checked attribute
https://bugs.webkit.org/show_bug.cgi?id=32571

Attachment 45846: Makes native checkedness take precedence when checking for
aria-checked. Now tests all permutations of checked and aria-checked.
https://bugs.webkit.org/attachment.cgi?id=45846&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   if (equalIgnoringCase(getAttribute(aria_checkedAttr).string(),
"true"))

You should omit the .string() here.

>      bool isRequired() const;
>      bool isSelected() const;
>      bool isExpanded() const;
> +    bool isChecked();

Why not const?

>      int hierarchicalLevel() const;
>      double clickPointX();
>      double clickPointY();

> +bool AccessibilityUIElement::isChecked()
> +{
> +    return static_cast<bool>(intValue());
> +}

Normally an int to bool conversion would not require an explicit cast.

> +    return (intValue() == 1);

No need for the parentheses here.

> +    return (vState.lVal & STATE_SYSTEM_CHECKED);

Or here.

r=me