[webkit-reviews] review denied: [Bug 35347] Convert the zoom mode into a proper enum : [Attachment 49498] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Feb 27 02:09:12 PST 2010
Adam Barth <abarth at webkit.org> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 35347: Convert the zoom mode into a proper enum
https://bugs.webkit.org/show_bug.cgi?id=35347
Attachment 49498: Patch
https://bugs.webkit.org/attachment.cgi?id=49498&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch doesn't build on Mac:
Undefined symbols:
"__ZN7WebCore5Frame13setZoomFactorEfb", referenced from:
-exported_symbols_list command line option
"__ZN7WebCore8Settings16setZoomsTextOnlyEb", referenced from:
-exported_symbols_list command line option
ld: symbol(s) not found
collect2: ld returned 1 exit status
** BUILD FAILED **
More information about the webkit-reviews
mailing list