[webkit-reviews] review denied: [Bug 34726] openDatabase() should not ignore the creationCallback if one is specified : [Attachment 49669] patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 34726: openDatabase() should not ignore the creationCallback if one is
specified
https://bugs.webkit.org/show_bug.cgi?id=34726

Attachment 49669: patch
https://bugs.webkit.org/attachment.cgi?id=49669&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks pretty good, but the one problem I saw is that we might not be
calling the database callback in the correct world.  You're only saving a
Frame* when you create the callback object.  You need to save something that
remembers which world we're in.  There should be some example code for this
pattern in the other code that makes callbacks.

Please add a test that the callback is called in the right world.  You can find
examples of these tests in the LayoutTests/http/tests/security/isolatedWorlds
directory.