[webkit-reviews] review granted: [Bug 35402] [GTK] Make webkit_web_view_grab_focus to active focus controller. : [Attachment 49529] proposed patch

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has granted Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>'s request for review:
Bug 35402: [GTK] Make webkit_web_view_grab_focus to active focus controller.
https://bugs.webkit.org/show_bug.cgi?id=35402

Attachment 49529: proposed patch
https://bugs.webkit.org/attachment.cgi?id=49529&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>

>+	 The code below is an wordaround: if the node has focus, a scroll

typo in 'wordaround'

>+	 action is performed and afterward it is checked if the adjustment
>+	 has to be different from 0.
>+    */


It would be nicer to not duplicate so much code between the tests by using
common setup/teardown methods like in other testfiles, but you can do it in a
follow-up if you feel like it.