[webkit-reviews] review requested: [Bug 35347] Convert the zoom mode into a proper enum : [Attachment 49498] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 26 07:27:08 PST 2010


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 35347: Convert the zoom mode into a proper enum
https://bugs.webkit.org/show_bug.cgi?id=35347

Attachment 49498: Patch
https://bugs.webkit.org/attachment.cgi?id=49498&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
We mark it for review again and see if the mac EWS barfs similarly.  Or someone
with a mac box tries to manually download the patch and builds it and reports
back the error.  Eventually we'll fix the commit-queue. :)

http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/statusserver.
py#L67
is the code that's failing.  It probably just needs to be smart enough to only
upload the last 500k of the file or similar.  Or more likely that method should
warn for large files and the callsites should be restricting the upload size.


More information about the webkit-reviews mailing list