[webkit-reviews] review denied: [Bug 35362] Parsing of CSS rgb() values is slow : [Attachment 49447] First draft

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 24 17:45:01 PST 2010


Oliver Hunt <oliver at apple.com> has denied Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 35362: Parsing of CSS rgb() values is slow
https://bugs.webkit.org/show_bug.cgi?id=35362

Attachment 49447: First draft
https://bugs.webkit.org/attachment.cgi?id=49447&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
String doesn't guarantee null termination, you should instead pass in a length
parameter, then you can do:
const UChar* end = *str + length;
and the *c pieces become
c != end


More information about the webkit-reviews mailing list