[webkit-reviews] review requested: [Bug 25648] When the video controls are updated the whole video is redisplayed (RenderSlider repaint). : [Attachment 49453] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 24 17:34:43 PST 2010


Hin-Chung Lam <hclam at google.com> has asked  for review:
Bug 25648: When the video controls are updated the whole video is  redisplayed
(RenderSlider repaint).
https://bugs.webkit.org/show_bug.cgi?id=25648

Attachment 49453: patch
https://bugs.webkit.org/attachment.cgi?id=49453&action=review

------- Additional Comments from Hin-Chung Lam <hclam at google.com>
I have changed the patch according to the comments:

1. Added the LayoutStateMaintainer back with offset being IntSize(x(), y())
2. Instead of tweaking the condition of objectisRelayoutBoundary(), make
RenderSlider to perform setNeedsLayout(true) when there is a mismatch between
the current height and the style of the thumb. This happens to me to be the
same as without the obj->isSlider() check in objectIsRelayoutBoundary()

Also included your test case into the layout test.


More information about the webkit-reviews mailing list