[webkit-reviews] review granted: [Bug 35260] Eliminate __apple_runtime_object : [Attachment 49240] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 35260: Eliminate __apple_runtime_object
https://bugs.webkit.org/show_bug.cgi?id=35260

Attachment 49240: proposed patch
https://bugs.webkit.org/attachment.cgi?id=49240&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +namespace JSC {
> +namespace Bindings {
> +class Instance;
> +}
> +}

That indentation is probably "right", but it looks so wrong!

> +	       HTMLElement* el = static_cast<JSHTMLElement*>(object)->impl();

How about using the entire word "element" here instead of "el"?

> +    Instance* instance = 0;

> -    RefPtr<Instance> instance = imp->getInternalInstance();

Any danger in the lifetime of instance here?

r=me