[webkit-reviews] review granted: [Bug 35162] Configure the root logging.logger globally for the Python scripts : [Attachment 49129] Proposed patch 2

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 35162: Configure the root logging.logger globally for the Python scripts
https://bugs.webkit.org/show_bug.cgi?id=35162

Attachment 49129: Proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=49129&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
 73	print "Logging disabled."
I would have written something like "Disabling logging while running the unit
tests."

I'm also not sure that we want to disable logging in the unit tests. We've used
logging in some of our unit tests to make sure that we execute all the code we
expect to.  Yes, they're a little brittle, but useful! :)

Otherwise this looks OK.