[webkit-reviews] review denied: [Bug 27481] onbeforeunload not called at window close + frame or iframe focused : [Attachment 48919] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied  review:
Bug 27481: onbeforeunload not called at window close + frame or iframe focused
https://bugs.webkit.org/show_bug.cgi?id=27481

Attachment 48919: Patch
https://bugs.webkit.org/attachment.cgi?id=48919&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This fails on my box too.  It looks like the new test is leaking state into
another test.  Did you run-webkit-tests before uploading this patch?

--- /tmp/layout-test-results/fast/events/onchange-click-hang-expected.txt      
2010-02-18 11:21:04.000000000 -0800
+++ /tmp/layout-test-results/fast/events/onchange-click-hang-actual.txt
2010-02-18 11:21:04.000000000 -0800
@@ -1,3 +1,4 @@
+ALERT: beforeUnload
 These checkboxes call their own and each others click() method from their
onchange callbacks. Click the first checkbox. This should not crash or hang.
This also shows that click() is protected on per-element basis.
  
 checkbox1 onchange enter