[webkit-reviews] review denied: [Bug 34902] [Qt] Added methods to QWebFrame for setting and consulting the CSS2 media type : [Attachment 48656] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 34902: [Qt] Added methods to QWebFrame for setting and consulting the CSS2
media type
https://bugs.webkit.org/show_bug.cgi?id=34902

Attachment 48656: Patch
https://bugs.webkit.org/attachment.cgi?id=48656&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Other than that I like the API. I think it should be a Q_PROPERTY.

It would be nice perhaps if the media type could be propagated down to child
frames. Theoretically the frame is the correct place, but given that child
frames can appear and disappear at will it only makes sense to set this
property on the persistent main frame, at which point to avoid disambigouties a
property on the page might be clearer.

I'm going to say r- because of the missing Q_PROPERTY and more importantly
because I feel it's not clear that this is the right place. Would love to hear
input from others on this. Mailing list? :)