[webkit-reviews] review granted: [Bug 35060] Reproducible crash in WebCore::nextLinePosition on Tweeteorites.com : [Attachment 48949] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Enrica Casucci <enrica at apple.com>'s request for
review:
Bug 35060: Reproducible crash in WebCore::nextLinePosition on Tweeteorites.com
https://bugs.webkit.org/show_bug.cgi?id=35060

Attachment 48949: Patch
https://bugs.webkit.org/attachment.cgi?id=48949&action=review

------- Additional Comments from mitz at webkit.org

> +</html>
> \ No newline at end of file

Please add a newline

> 
> Property changes on:
LayoutTests/editing/selection/extend-byline-withfloat.html
> ___________________________________________________________________
> Added: svn:executable
>    + *

And don’t set the executable bit on the test.

The test as it stands may depend on font metrics, and since it specifies
Helvetica, it may not work on all platforms. Not sure if that’s going to be a
problem.