[webkit-reviews] review requested: [Bug 35048] an 'undefined' return value from a statement error callback should be treated as 'true' : [Attachment 48953] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 17 17:49:32 PST 2010


Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 35048: an 'undefined' return value from a statement error callback should
be treated as 'true'
https://bugs.webkit.org/show_bug.cgi?id=35048

Attachment 48953: patch
https://bugs.webkit.org/attachment.cgi?id=48953&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
(In reply to comment #4)
> (From update of attachment 48946 [details])
> What about null? Should that still be false?

fixed. treating all non-boolean values as 'true' (since the spec seems to
divide all return values into 'false' and 'everything else'). also added more
test cases to storage/statement-error-callback.html to test all kind of
non-boolean return types (including 'null').


More information about the webkit-reviews mailing list