[webkit-reviews] review denied: [Bug 16662] CSS3: Implement calc() : [Attachment 48285] full patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 12 14:07:29 PST 2010
Sam Weinig <sam at webkit.org> has denied Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 16662: CSS3: Implement calc()
https://bugs.webkit.org/show_bug.cgi?id=16662
Attachment 48285: full patch v2
https://bugs.webkit.org/attachment.cgi?id=48285&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
The changes to Length.h/cpp are layering violation. The intent of the platform
layer is that it has no knowledge of the classes such as those in the dom, css
and rendering directories. This violation needs to be fixed before going
forward.
r-.
More information about the webkit-reviews
mailing list