[webkit-reviews] review granted: [Bug 33731] [Dupe of] Many false leaks in release builds due to PtrAndFlags : [Attachment 48663] New StringImpl patch, also fix bufferIsInternal bug that was being triggered.

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 33731: [Dupe of] Many false leaks in release builds due to PtrAndFlags
https://bugs.webkit.org/show_bug.cgi?id=33731

Attachment 48663: New StringImpl patch, also fix bufferIsInternal bug that was
being triggered.
https://bugs.webkit.org/attachment.cgi?id=48663&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 54731)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,38 @@
> +2010-02-12  Gavin Barraclough  <barraclough at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=33731
> +	   Remove uses of PtrAndFlags from WebCore::StringImpl.
> +
> +	   These break the OS X Leaks tool.  Move the management of
null-terminated copies
> +	   out from StringImpl to String, and use a bits stolen from the
refCount to hold the

LIES!

Please fix the change log and add the extra assert in the StringImpl
destructor.

Otherwise, r=me.