[webkit-reviews] review canceled: [Bug 34507] [Qt] Minor improvement to hybrid QPixmap : [Attachment 47984] minor adjustment to hybrid pixmap: allow sending an existing img element as an argument

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 11 21:27:17 PST 2010


Noam Rosenthal <noam.rosenthal at nokia.com> has canceled Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 34507: [Qt] Minor improvement to hybrid QPixmap
https://bugs.webkit.org/show_bug.cgi?id=34507

Attachment 47984: minor adjustment to hybrid pixmap: allow sending an existing
img element as an argument
https://bugs.webkit.org/attachment.cgi?id=47984&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
Based on comments from Kenneth, renamed toHTMLImageElement to two functions: 
createHTMLImageElement and applyToHTMLImageElement (which takes an existing img
element as an argument).
Also added some in-code comments.


More information about the webkit-reviews mailing list