[webkit-reviews] review requested: [Bug 34507] [Qt] Minor improvement to hybrid QPixmap : [Attachment 48620] enable applying a QPixmap from a native QObject to an HTML img element

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 11 21:27:18 PST 2010


Noam Rosenthal <noam.rosenthal at nokia.com> has asked  for review:
Bug 34507: [Qt] Minor improvement to hybrid QPixmap
https://bugs.webkit.org/show_bug.cgi?id=34507

Attachment 48620: enable applying a QPixmap from a native QObject to an HTML
img element
https://bugs.webkit.org/attachment.cgi?id=48620&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
Based on comments from Kenneth, renamed toHTMLImageElement to two functions: 
createHTMLImageElement and applyToHTMLImageElement (which takes an existing img
element as an argument).
Also added some in-code comments.


More information about the webkit-reviews mailing list