[webkit-reviews] review granted: [Bug 34673] Crash in Flash at http://www.cctv.com/ : [Attachment 48425] patch v6

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 10 10:39:35 PST 2010


Darin Adler <darin at apple.com> has granted Jon Honeycutt
<jhoneycutt at apple.com>'s request for review:
Bug 34673: Crash in Flash at http://www.cctv.com/
https://bugs.webkit.org/show_bug.cgi?id=34673

Attachment 48425: patch v6
https://bugs.webkit.org/attachment.cgi?id=48425&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   // There is a crash in Flash when evaluating a script that destroys
the
> +	   // PluginView, so we destroy is asynchronously.

Typo:"destroy is" with "destroy it".

> +static void executeScript(const PluginObject* obj, const char* script)

We should use "object" instead of "obj".

r=me


More information about the webkit-reviews mailing list