[webkit-reviews] review denied: [Bug 34783] Fix two issues on maxLength. : [Attachment 48461] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 34783: Fix two issues on maxLength.
https://bugs.webkit.org/show_bug.cgi?id=34783

Attachment 48461: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=48461&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +debug('<br />Non-dirty value');

It's better not to rely on markup in the debug function. I typically use
debug('') to make a blank line. Someone should clean this up a bit for future
tests.

The setNonDirtyValue affects a lot of different functions. There is not
sufficient test coverage for this. Each function that you changed to call
setNonDirtyValue needs a test that would fail if it was still calling setValue.


I'm going to say review- because of not enough test coverage. Everything else
seems OK in the patch. If I'm wrong about the test coverage, please let me
know.