[webkit-reviews] review requested: [Bug 34624] window.close() should only work if opened via script. : [Attachment 48345] Patch2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 8 10:58:45 PST 2010
Kavita Kanetkar <kkanetkar at chromium.org> has asked for review:
Bug 34624: window.close() should only work if opened via script.
https://bugs.webkit.org/show_bug.cgi?id=34624
Attachment 48345: Patch2
https://bugs.webkit.org/attachment.cgi?id=48345&action=review
------- Additional Comments from Kavita Kanetkar <kkanetkar at chromium.org>
Thanks for the review.
>From what I understand the htlm5 spec says : allow window.close() if script
opened it, do not allow otherwise.
The original bug was filed to reflect this.
This patch removes the page->getHistoryLength() from the condition.
If it's not approved, I can close both the bugs (this and the original one in
Chromium) and the behavior stays unchanged.
More information about the webkit-reviews
mailing list