[webkit-reviews] review canceled: [Bug 34624] window.close() should only work if opened via script. : [Attachment 48185] proposed fix

[bugzilla-daemon at webkit.org]

Kavita Kanetkar <kkanetkar at chromium.org> has canceled Kavita Kanetkar
<kkanetkar at chromium.org>'s request for review:
Bug 34624: window.close() should only work if opened via script.
https://bugs.webkit.org/show_bug.cgi?id=34624

Attachment 48185: proposed fix
https://bugs.webkit.org/attachment.cgi?id=48185&action=review

------- Additional Comments from Kavita Kanetkar <kkanetkar at chromium.org>
Thanks for the review. 

>From what I understand the htlm5 spec says : allow window.close() if script
opened it, do not allow otherwise.
The original bug was filed to reflect this. 

This patch removes the page->getHistoryLength() from the condition.
If it's not approved, I can close both the bugs (this and the original one in
Chromium) and the behavior stays unchanged.